Huaisi Xu has posted comments on this change. Change subject: IMPALA-3687: Prefer Avro field name during schema reconciliation ......................................................................
Patch Set 6: (3 comments) > (1 comment) > > I still think that we're missing some testing for this patch. What > was the original use for which this jira was filed? If it the one > mentioned in the JIRA, I don't see why we can generate a test case > for it? Can't we simply have two files pointing to two slightly > different Avro schemas and apply the steps from the JIRA. Dan what > do you think? but avro.schema.url and avro.schema.literal are the same... ? http://gerrit.cloudera.org:8080/#/c/3331/5/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java: PS5, Line 119: AnalysisException > In the context of this particular function, what is interesting is that an Done http://gerrit.cloudera.org:8080/#/c/3331/6/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java: PS6, Line 111: columns > does it mean "schema"? will do Line 136: // as a CHAR/VARCHAR/STRING in the reconciled schema. Column name and comment > I discussed this with Alex in the past. From what I understand all this rec another reason is that we did this before so it is hard to drop it. ideally we should not support char/varchar, which is not supported in avro's standard. hive does not support this case as well. but it is hard for us to "go back". -- To view, visit http://gerrit.cloudera.org:8080/3331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e43b2885853c2b4f207a45a873c9d7f31379cd Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-HasComments: Yes
