Huaisi Xu has posted comments on this change. Change subject: IMPALA-3687: Prefer Avro field name during schema reconciliation ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/3331/6//COMMIT_MSG Commit Message: Line 9: Currently Impala prefers schema definition from schema definition > How about something like the following blurb. will do http://gerrit.cloudera.org:8080/#/c/3331/6/fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java File fe/src/main/java/com/cloudera/impala/util/AvroSchemaUtils.java: Line 136: // as a CHAR/VARCHAR/STRING in the reconciled schema. Column name and comment > I agree with Juan, and I think we all agree with her. This reconciliation l I agree that we should not allow this things. but I disagree that this change breaks compatibility. I think it was a bug that we treat string column the same as char/varchar column. Maybe a purer bug fix is to only fix STRING column? what do you think? Line 143: reconciledColDef.analyze(); > analysis should never fail, might as well try catch with a Preconditions ch will do http://gerrit.cloudera.org:8080/#/c/3331/6/testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test File testdata/workloads/functional-query/queries/QueryTest/avro-schema-resolution.test: Line 95: {"type": ["int", "null"], "name": "id_mismatch", "doc": "int comment mismatch"}, > Dimitris' request to include the original test case seems reasonable. We ca Done -- To view, visit http://gerrit.cloudera.org:8080/3331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3e43b2885853c2b4f207a45a873c9d7f31379cd Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-HasComments: Yes
