Huaisi Xu has posted comments on this change. Change subject: Revert "IMPALA-2473: reduce scanner memory usage" ......................................................................
Patch Set 1: Local testing in a vm shows reverting this on 57x is 2x slower than on 5.4.10. I verified that the returned row batch contains 1024 rows in aggregation node. most of the time is still spent in scanner. Tim you know what may went wrong? I have conflict showed in the commit message to give you an idea for code review. I am not that sure about row-batch.h's revert. could you take a look? -- To view, visit http://gerrit.cloudera.org:8080/3429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55a94363840c2b3804ed070c23f57f2117b4fab3 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.x Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: No
