Tim Armstrong has posted comments on this change. Change subject: Revert "IMPALA-2473: reduce scanner memory usage" ......................................................................
Patch Set 1: (4 comments) I think we should only backport the changes to hdfs-parquet-scanner.cc and nested-types-tpch.test. http://gerrit.cloudera.org:8080/#/c/3429/1/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1646 I think this is the only change we need to backport. http://gerrit.cloudera.org:8080/#/c/3429/1/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: Line 173 Don't need to revert this change. http://gerrit.cloudera.org:8080/#/c/3429/1/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Let's not revert the changes in this file. http://gerrit.cloudera.org:8080/#/c/3429/1/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: Line 139: bool AtCapacity(MemPool* tuple_pool) { We don't want to backport this change. -- To view, visit http://gerrit.cloudera.org:8080/3429 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55a94363840c2b3804ed070c23f57f2117b4fab3 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.x Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
