Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout ......................................................................
Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/3343/11/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: PS11, Line 272: bool* can_retry = NULL Would it be easy to just pass a 'int num_retry' here, so that the retry loop can go within this function? That would mean less function calls and also one less pointer dereference. If it's not straightforward to do so, then this is fine. PS11, Line 281: //status = WaitRpcResp(wait_func, response, state, timeout); Is this logic complete? Or will you be posting another patch? -- To view, visit http://gerrit.cloudera.org:8080/3343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6723cfe58df6217f4a9cdd12facd320cbc24964 Gerrit-PatchSet: 11 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Alan Choi <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
