Juan Yu has posted comments on this change. Change subject: IMPALA-3575: Add retry to backend connection request and rpc timeout ......................................................................
Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/3343/11/be/src/runtime/client-cache.h File be/src/runtime/client-cache.h: PS11, Line 272: bool* can_retry = NULL > Would it be easy to just pass a 'int num_retry' here, so that the retry loo I am afraid that way this function does too much. I prefer to leave the retry to caller, so caller can decide to use the same connection or a new connection, or adding some delay between retry. PS11, Line 281: //status = WaitRpcResp(wait_func, response, state, timeout); > Is this logic complete? Or will you be posting another patch? sorry forget to remove the old code. and I do need to post a new patch. just found that RuntimeState might not always be available. -- To view, visit http://gerrit.cloudera.org:8080/3343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6723cfe58df6217f4a9cdd12facd320cbc24964 Gerrit-PatchSet: 11 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Alan Choi <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
