Jim Apple has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3401/5/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 767: char ConstantReplacementPass::pass_id_ = 0; I think you can make this a constexpr and do in-class initialization http://gerrit.cloudera.org:8080/#/c/3401/4/be/src/exprs/expr.cc File be/src/exprs/expr.cc: Line 599: } else { > Done This looks unchanged to me in PS5. Do you mean "Done" as in "Considered; declined". If so, can you elaborate on why? http://gerrit.cloudera.org:8080/#/c/3401/4/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: PS4, Line 202: > It should be safe here: I can't think of any possible scenario where a stat Can you elaborate to me on why a static initializer would be very unlikely to ever do codegen? -- To view, visit http://gerrit.cloudera.org:8080/3401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ba029ed8589698eb15dbfb0a20dd2a7ea752635 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
