Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement
......................................................................
Patch Set 6:
I ran a local TPC-H run. There was a small improvement within the margin of
error, which is what I expected.
Report Generated on 2016-06-22
Run Description: "Base: 2a2412ad0835dcb56773d25472dbdf92eadfd722 vs Ref:
cbbbad3e13a8bb30fc77ecd1c757e211924ffbab"
Cluster Name: UNKNOWN
Lab Run Info: UNKNOWN
Impala Version: impalad version 2.6.0-cdh5-INTERNAL RELEASE ()
Baseline Impala Version: impalad version 2.6.0-cdh5-INTERNAL RELEASE ()
+-----------+-----------------------+---------+------------+------------+----------------+
| Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) |
Delta(GeoMean) |
+-----------+-----------------------+---------+------------+------------+----------------+
| TPCH(_20) | parquet / none / none | 9.48 | -0.44% | 6.26 |
-1.48% |
+-----------+-----------------------+---------+------------+------------+----------------+
+-----------+----------+-----------------------+--------+-------------+------------+------------+----------------+-------------+-------+
| Workload | Query | File Format | Avg(s) | Base Avg(s) |
Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters |
+-----------+----------+-----------------------+--------+-------------+------------+------------+----------------+-------------+-------+
| TPCH(_20) | TPCH-Q13 | parquet / none / none | 10.63 | 10.21 |
+4.12% | 5.35% | 6.25% | 1 | 10 |
| TPCH(_20) | TPCH-Q3 | parquet / none / none | 5.06 | 4.97 |
+1.79% | 1.64% | 1.55% | 1 | 10 |
| TPCH(_20) | TPCH-Q9 | parquet / none / none | 13.93 | 13.76 |
+1.27% | 1.57% | 1.57% | 1 | 10 |
| TPCH(_20) | TPCH-Q21 | parquet / none / none | 23.37 | 23.12 |
+1.09% | 0.89% | 0.93% | 1 | 10 |
| TPCH(_20) | TPCH-Q17 | parquet / none / none | 14.73 | 14.66 |
+0.46% | 1.34% | 3.45% | 1 | 10 |
| TPCH(_20) | TPCH-Q7 | parquet / none / none | 16.83 | 16.82 |
+0.04% | 3.67% | 2.37% | 1 | 10 |
| TPCH(_20) | TPCH-Q15 | parquet / none / none | 5.04 | 5.04 |
-0.03% | 2.90% | 2.09% | 1 | 10 |
| TPCH(_20) | TPCH-Q12 | parquet / none / none | 4.25 | 4.26 |
-0.27% | 1.74% | 1.51% | 1 | 10 |
| TPCH(_20) | TPCH-Q10 | parquet / none / none | 6.58 | 6.61 |
-0.40% | 2.13% | 1.14% | 1 | 10 |
| TPCH(_20) | TPCH-Q19 | parquet / none / none | 48.62 | 48.98 |
-0.73% | 3.21% | 1.90% | 1 | 10 |
| TPCH(_20) | TPCH-Q5 | parquet / none / none | 4.52 | 4.56 |
-0.95% | 0.93% | 1.55% | 1 | 10 |
| TPCH(_20) | TPCH-Q14 | parquet / none / none | 3.45 | 3.48 |
-1.08% | 1.98% | 2.15% | 1 | 10 |
| TPCH(_20) | TPCH-Q22 | parquet / none / none | 2.78 | 2.81 |
-1.15% | 2.39% | 1.67% | 1 | 10 |
| TPCH(_20) | TPCH-Q6 | parquet / none / none | 2.34 | 2.38 |
-1.54% | 0.87% | 1.31% | 1 | 10 |
| TPCH(_20) | TPCH-Q18 | parquet / none / none | 15.11 | 15.35 |
-1.56% | 3.76% | 3.46% | 1 | 10 |
| TPCH(_20) | TPCH-Q8 | parquet / none / none | 6.53 | 6.64 |
-1.69% | 2.11% | 2.79% | 1 | 10 |
| TPCH(_20) | TPCH-Q20 | parquet / none / none | 3.86 | 3.95 |
-2.24% | 1.50% | 1.36% | 1 | 10 |
| TPCH(_20) | TPCH-Q1 | parquet / none / none | 11.32 | 11.63 |
-2.69% | 0.97% | 2.41% | 1 | 10 |
| TPCH(_20) | TPCH-Q2 | parquet / none / none | 2.39 | 2.48 |
-3.32% | 1.54% | 4.92% | 1 | 10 |
| TPCH(_20) | TPCH-Q16 | parquet / none / none | 2.19 | 2.32 |
-5.43% | 2.81% | 4.50% | 1 | 10 |
| TPCH(_20) | TPCH-Q4 | parquet / none / none | 3.68 | 3.93 |
-6.54% | * 20.47% * | * 20.62% * | 1 | 10 |
| TPCH(_20) | TPCH-Q11 | parquet / none / none | 1.35 | 1.51 |
-11.06% | 1.12% | 1.85% | 1 | 10 |
+-----------+----------+-----------------------+--------+-------------+------------+------------+----------------+-------------+-------+
(V) Significant Variability: TPCH(_20) TPCH-Q4 [parquet / none / none]
(20.62% -> 20.47%)
+--------------+------------+-----------+----------------+------------------+--------+-------+-----------+
| Operator | % of Query | StdDev(%) | Base StdDev(%) | Delta(StdDev(%))
| #Hosts | #Rows | Est #Rows |
+--------------+------------+-----------+----------------+------------------+--------+-------+-----------+
| 08:AGGREGATE | 3.32% | 20.45% | 16.72% | +22.29%
| 1 | 5 | 5 |
| 03:AGGREGATE | 9.39% | 12.69% | 15.20% | -16.50%
| 1 | 5 | 5 |
| 02:HASH JOIN | 18.84% | 25.29% | 34.47% | -26.62%
| 1 | 1.05M | 3.00M |
| 00:SCAN HDFS | 17.19% | 13.15% | 13.09% | +0.44%
| 1 | 1.15M | 3.00M |
| 05:EXCHANGE | 3.48% | 51.18% | 56.64% | -9.63%
| 1 | 6.02M | 12.00M |
+--------------+------------+-----------+----------------+------------------+--------+-------+-----------+
--
To view, visit http://gerrit.cloudera.org:8080/3401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ba029ed8589698eb15dbfb0a20dd2a7ea752635
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No
