Youwei Wang has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3213/2/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: Line 785: MACRO_TRIM_CHECK > What does the ISO doc say? Greetings, Jim. Please refer this link: http://troels.arvin.dk/db/rdbms/#functions-TRIM As for trim section, there exists such description “Core SQL feature ID E021-09: TRIM(where characters FROM string_to_be_trimmed) where may be one of LEADING, TRAILING or BOTH—or omitted which implies BOTH.” Here is another link which may be useful: http://www.contrib.andrew.cmu.edu/~shadow/sql/sql1992.txt Please goto the context of following description: “b) If <trim specification> is not specified, then BOTH is implicit.” Thanks. -- To view, visit http://gerrit.cloudera.org:8080/3213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4753c608b0b00569bf8c5e95b132df6df358e602 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
