Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3213/7//COMMIT_MSG Commit Message: PS7, Line 9: ISO-SQL compliant This doesn't look ISO-SQL compliant. Looking at the standard links you provided, the standard syntax is TRIM($where $characters FROM $string_to_be_trimmed) http://gerrit.cloudera.org:8080/#/c/3213/7/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 2009: TestStringValue("btrim('%%%%%abcdefg%%%%%', '%', 'lEfT')", "abcdefg%%%%%"); Can you break this into secions with a short comment describing what each section is testing, like "Invalid third arguments cause no trimming to occur". -- To view, visit http://gerrit.cloudera.org:8080/3213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4753c608b0b00569bf8c5e95b132df6df358e602 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
