Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables ......................................................................
Patch Set 1: (3 comments) this does need a test. http://gerrit.cloudera.org:8080/#/c/3474/1//COMMIT_MSG Commit Message: Line 16: 1) Hive's underlying database contains a column, which is not present in "a column which", unless you mean there's only a single column Line 18: in DescribeResultFactory.java#L189 when trying to lookup the column in to look up http://gerrit.cloudera.org:8080/#/c/3474/1/fe/src/main/java/com/cloudera/impala/service/DescribeResultFactory.java File fe/src/main/java/com/cloudera/impala/service/DescribeResultFactory.java: Line 187 what was the rationale for the logic below? (and why don't we need it anymore?) -- To view, visit http://gerrit.cloudera.org:8080/3474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic640f18acf7a1731f34b22c50ebbb462dfee78bd Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
