Lars Volker has posted comments on this change. Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables ......................................................................
Patch Set 1: (3 comments) Thanks for the comments. I don't know how to automatically test this. For the manual tests I created an avro table and then updated the schema file for case 1 and deleted some entries in COLUMNS_V2 in the underlying postgres database for case 2. This is how we tested https://gerrit.cloudera.org/#/c/3446/, too. If you have an idea how to automatically test this, please let me know. http://gerrit.cloudera.org:8080/#/c/3474/1//COMMIT_MSG Commit Message: Line 16: 1) Hive's underlying database contains a column, which is not present in > "a column which", unless you mean there's only a single column Done Line 18: in DescribeResultFactory.java#L189 when trying to lookup the column in > to look up Done http://gerrit.cloudera.org:8080/#/c/3474/1/fe/src/main/java/com/cloudera/impala/service/DescribeResultFactory.java File fe/src/main/java/com/cloudera/impala/service/DescribeResultFactory.java: Line 187 > what was the rationale for the logic below? (and why don't we need it anymo The rational seems to have been that we transfer all comments from our internal table object's column list to the columns retrieved from the metastore. Since we now retrieve the columns from our internal table object altogether, including the comments, we don't need to copy them separately. -- To view, visit http://gerrit.cloudera.org:8080/3474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic640f18acf7a1731f34b22c50ebbb462dfee78bd Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
