Hello Casey Ching, Internal Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2651
to look at the new patch set (#7).
Change subject: IMPALA-3253: Modify gen_build_version.sh to always output the
right version
......................................................................
IMPALA-3253: Modify gen_build_version.sh to always output the right version
gen_build_version.sh previously had a --noclean option which did not
overwrite the version information if it was already populated. Since
--noclean was the default option, it always never updated the version
information.
This patch modifies gen_build_version.py to generate a
common/version.cc instead of a common/version.h. Now,
common/version.h will be a part of the git repo and will not need to
be modified on every build. It declares the functions that will return
the build information. These functions will be defined in
common/version.cc and the build information will change on every new
build.
Since only the .cc file changes on every build, we will not incur a
highly noticable change in build times.
Also changed the function names from GetImpalaBuild...() to
GetImpaladBuild...() so as to avoid naming confusion between the
Impala-lzo and the Impala functions.
There is an accompanying change in the Impala-lzo library too.
Change-Id: Ie461110b6f8ca545f04ea33b7b502aea550b8551
---
M be/.gitignore
M be/src/common/CMakeLists.txt
A be/src/common/version.h
M be/src/exec/hdfs-lzo-text-scanner.cc
M be/src/exec/hdfs-parquet-table-writer.cc
M be/src/service/impala-hs2-server.cc
M be/src/util/debug-util.cc
M bin/gen_build_version.py
M bin/make_impala.sh
9 files changed, 72 insertions(+), 38 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/51/2651/7
--
To view, visit http://gerrit.cloudera.org:8080/2651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie461110b6f8ca545f04ea33b7b502aea550b8551
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Casey Ching <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
