Dan Hecht has posted comments on this change. Change subject: IMPALA-3253: Modify gen_build_version.sh to always output the right version ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/2651/7/be/src/common/version.h File be/src/common/version.h: PS7, Line 18: GetImpaladBuildVersion This is really close to lzo's GetImpalaBuildVersion() which makes it hard to notice (my first time through I didn't notice the missing "d" in the lzo case and was confused). Also, it is used by other daemons (catalogd, statestored), so maybe just call these: GetBuildVersion() etc? -- To view, visit http://gerrit.cloudera.org:8080/2651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie461110b6f8ca545f04ea33b7b502aea550b8551 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
