Michael Brown has posted comments on this change. Change subject: Clean up Python test import statements ......................................................................
Patch Set 2: (2 comments) Can you run the following tests: 1. debug build / exhaustive tests / HDFS 2. debug build / core tests / S3 3. query generator / leopard smoke test http://gerrit.cloudera.org:8080/#/c/3444/2/tests/comparison/db_connection.py File tests/comparison/db_connection.py: Line 933 Whoops. Is this the correct fix though? How will this work without using a MySQLdb connection? Why not merge the two MySQLConnection classes' methods? http://gerrit.cloudera.org:8080/#/c/3444/2/tests/comparison/query.py File tests/comparison/query.py: PS2, Line 613: return LimitClause(self.limit) This isn't an import change. Was it intentional in this patch? -- To view, visit http://gerrit.cloudera.org:8080/3444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
