Michael Brown has posted comments on this change. Change subject: Clean up Python test import statements ......................................................................
Patch Set 3: Code-Review+2 I didn't review that all your imports were truly functionally correct, of course, but I'm satisfied doing an exhaustive test run and a test run of at least one other filesystem is enough to verify import changes are still working. Furthermore your test runs are recent enough that this seems OK. I looked more carefully at the non-import changes in this patch, such as removing unneeded variables, and those look fine. Do you mind sharing what tools you used to do this? I'm only familiar with flake8 and there are so many other flake8 violations in our python that I don't use that on the entire python codebase. -- To view, visit http://gerrit.cloudera.org:8080/3444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a33bb66552ae657d1725f765842f648faeb26a8 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
