Lars Volker has posted comments on this change. Change subject: IMPALA-3799: Make MAX_SCAN_RANGE_LENGTH accept formatted quantities ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3573/1/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: Line 91: {"9223372036854775808", -1} // 2**63 should we also add values that are incorrectly formatted? Are lowercase units also supported? Line 93: for (auto& val: vals) { nit: const auto& -- To view, visit http://gerrit.cloudera.org:8080/3573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2703f7ddaa74c4256a3d4a545012332dfbf5fed8 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
