Henry Robinson has posted comments on this change. Change subject: IMPALA-3799: Make MAX_SCAN_RANGE_LENGTH accept formatted quantities ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3573/1/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: Line 91: {"9223372036854775808", -1}, // 2**63 > should we also add values that are incorrectly formatted? Are lowercase uni It can't hurt to have one badly formatted test. But in general the parsing code should be covered by parse-util-test.cc, i.e. we shouldn't test that the parsing code works as expected in all cases here. Line 93: for (const auto& val: vals) { > nit: const auto& Done -- To view, visit http://gerrit.cloudera.org:8080/3573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2703f7ddaa74c4256a3d4a545012332dfbf5fed8 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
