Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-2347: Reuse metastore client connections in Catalog
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3381/6/fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java
File fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java:

PS6, Line 35: 32
> Out of curiosity, do we know if HMS has a limit on the number of open conne
This seems to be controlled by two params "hive.metastore.server.min.threads" 
(defaults to 200) and "hive.metastore.server.max.threads" (defaults to 100000), 
which imo are very large.


Line 82:       // Ensure the connection isn't returned to the pool if the pool 
has been closed.
> "or if the number of connections in the pool exceed MAX_HMS_CONNECTION_POOL
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3381
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I517c0e1efef2584cd8d34017b33574f2ad69bd52
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to