Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2347: Reuse metastore client connections in Catalog ......................................................................
Patch Set 7: I agree that option #3 seems like the best option, but we need to answer a few questions first: 1. How stable is that implementation? Is it currently used in production and since when? 2. Are there any performance implications if we switch to the retrying metastore client? We probably need to repeat the perf evaluation you did using JMeter. It wouldn't be a bad idea to share the perf methodology and results with Mostafa. He may have more interesting use cases/workloads that are worth testing. 3. Another option, in case we don't feel comfortable with the existing implementation of the retry client, is to create our own retry logic. Not ideal but just something to consider. -- To view, visit http://gerrit.cloudera.org:8080/3381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I517c0e1efef2584cd8d34017b33574f2ad69bd52 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: No
