Youwei Wang has posted comments on this change.

Change subject: IMPALA-889: Add support for ISO-SQL trim()
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3213/7//COMMIT_MSG
Commit Message:

PS7, Line 9: ISO-SQL compliant
> When you say "Previous syntax follows the request of one customer", what is
Hi Jim. When talking about "Previous syntax", I actually refer to this:
  select trim(source_string, chars_to_trim, option);
comparing to the latest one:
  select trim(option, chars_to_trim, source_string);

I have seen your proposal at that JIRA. I will wait for your decision of how to 
move on. Thank you so much for your great effort! :)


-- 
To view, visit http://gerrit.cloudera.org:8080/3213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4753c608b0b00569bf8c5e95b132df6df358e602
Gerrit-PatchSet: 10
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Youwei Wang <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Youwei Wang <[email protected]>
Gerrit-HasComments: Yes

Reply via email to