Lars Volker has posted comments on this change. Change subject: IMPALA-3839: Fix race condition in impala_cluster.py ......................................................................
Patch Set 1: Code-Review+2 (2 comments) Thanks for the reviews. I addressed them in PS. +2 from Tim and David. http://gerrit.cloudera.org:8080/#/c/3592/1/tests/common/impala_cluster.py File tests/common/impala_cluster.py: Line 99: try: > It would be kind of nice to share this with start-impala-cluster.py but I d They don't share any code at the moment, start-impala-cluster.py looks like it does everything by itself. It's probably better to refactor it in a subsequent change. I opened IMPALA-3846 for the refactoring, David, can you triage that? PS1, Line 110: >=1 > missing space Done -- To view, visit http://gerrit.cloudera.org:8080/3592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
