Hello David Knupp, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3592
to look at the new patch set (#2).
Change subject: IMPALA-3839: Fix race condition in impala_cluster.py
......................................................................
IMPALA-3839: Fix race condition in impala_cluster.py
Accesses to properties of Process objects from psutil hit the operating
system, at least under Linux. Therefore any access can throw
NoSuchProcess if the underlying process has already terminated. The fix
extends the try/except block to all such accesses.
To ensure that this change does not introduce a regression I ran
test_breakpad.py, which exercises this code. I also ran
test_breakpad.py:test_sigusr1_writes_minidump() in a loop for about 40
iterations with the changes from https://gerrit.cloudera.org/#/c/3312/6,
which made me discover this issue in the first place.
Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
---
M tests/common/impala_cluster.py
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/92/3592/2
--
To view, visit http://gerrit.cloudera.org:8080/3592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c0d5e43f8c58b4922ab5db78236915fcc8b588d
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
