Michael Ho has posted comments on this change. Change subject: IMPALA-2885: ScannerContext::Stream objects should be owned by ScannerContext ......................................................................
Patch Set 4: The reason is that we have the following in ScannerContext::ReleaseCompletedResources(): if (done) streams_.clear(); The fact that the streams_ vector is being cleared suggests that no consumer should access the stream anymore from that point onwards. -- To view, visit http://gerrit.cloudera.org:8080/3590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5440d414ecc0ca19676c553275aeb85231d6045 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
