Michael Ho has posted comments on this change. Change subject: IMPALA-2885: ScannerContext::Stream objects should be owned by ScannerContext ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3590/4/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 194: scan_node_->RangeComplete(THdfsFileFormat::TEXT, compression_type); > is it important that RangeComplete() is called after AddFinalRowBatch(), or Done. As far as I can tell, RangeComplete() is not mostly updating stat counters so I don't see any reason why it cannot be done earlier. -- To view, visit http://gerrit.cloudera.org:8080/3590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5440d414ecc0ca19676c553275aeb85231d6045 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
