Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3756: Fix wrong argument type in HiveStringsTest ......................................................................
Patch Set 1: It's weird to me that this only happens on code coverage builds. It looks like at runtime we probably loaded the wrong overload of evaluate(), since one takes a Text and another takes a BytesWritable. (We'd have to verify maybe by printing more output.) But I'm worried there might be a bug in our Hive UDF loading code, UdfExecutor.init(). I'm thinking there could be something dependent on the order in which the jvm loads something, and possibly we match the wrong overload. I'm suspicious of UdfExecutor:650, which compares TPrimitiveTypes. -- To view, visit http://gerrit.cloudera.org:8080/3617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I662e6286dac601ae0e45f18545ef149724aa047e Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: No
