Alex Behm has posted comments on this change. Change subject: IMPALA-3756: Fix wrong argument type in HiveStringsTest ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3617/1/fe/src/test/java/com/cloudera/impala/hive/executor/UdfExecutorTest.java File fe/src/test/java/com/cloudera/impala/hive/executor/UdfExecutorTest.java: Line 339: TestHiveUdf(UDFLength.class, createInt(5), "Hello"); As discussed offline, I think there is actually a real bug hidden here. I think it's going wrong right here, leading us to accept and run against a method with an incompatible signature: https://github.com/cloudera/Impala/blob/cdh5-trunk/fe/src/main/java/com/cloudera/impala/hive/executor/UdfExecutor.java#L606 -- To view, visit http://gerrit.cloudera.org:8080/3617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I662e6286dac601ae0e45f18545ef149724aa047e Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
