Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3159: impala-shell does not accept wildcard or SAN certificates ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3615/2/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: Line 88: @pytest.mark.execute_serially May be you can add some -ve test cases like trying to connect without --ssl or specifying incorrect/unreadable cert etc.? Line 92: def test_wildcard_ssl(self, vector): Does openssl allow adding both wildcard and SAN to the same cert? If yes, should we test that combination? -- To view, visit http://gerrit.cloudera.org:8080/3615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8908f05afe4a6da9713fd303c499c50f692985ef Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
