Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3159: impala-shell does not accept wildcard or SAN certificates ......................................................................
Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/3615/4/be/src/testutil/bad-cert.key File be/src/testutil/bad-cert.key: Line 1 > Can you add a text file to this directory listing what every key / cert fil Added certificates-info.txt. http://gerrit.cloudera.org:8080/#/c/3615/4/shell/TSSLSocketWithWildcardSAN.py File shell/TSSLSocketWithWildcardSAN.py: Line 24: > needs a class comment Done http://gerrit.cloudera.org:8080/#/c/3615/4/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: PS4, Line 37: > nit: just for neatness, consider enclosing these in parentheses. Then I don Done Line 57: > negative cases here as well? Done PS4, Line 112: > Is it an incorrect cert, or a badly formatted one? If it's the former, "bad It is an incorrect certificate. I've changed the name to reflect that. PS4, Line 112: > an Done PS4, Line 121: gs = "-q 'select 1 + > _validate_positive_cases()? Done Line 127: result = run_impala_shell_cmd(shell_options) > for completeness, add a test that confirms this works when just --ssl is sp Done -- To view, visit http://gerrit.cloudera.org:8080/3615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8908f05afe4a6da9713fd303c499c50f692985ef Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
