Michael Ho has posted comments on this change. Change subject: IMPALA-1731: StringToFloatInternal() does not handle inf correctly ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3622/1/be/src/util/string-parser.h File be/src/util/string-parser.h: PS1, Line 422: } else if (s[i] == '.') { : decimal = true; > Not your change but I just noticed that we treat cast("2.3....3" as float) I meant cast("2.3....3" as float) is treated the same as cast("2.33" as float). This is probably a bug. -- To view, visit http://gerrit.cloudera.org:8080/3622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e17d0f051b300a22a520ce34e276c2d4460d35e Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
