Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3622/2/be/src/util/string-parser.h File be/src/util/string-parser.h: PS2, Line 377: We'll be a little loose : // here and interpret any column with "inf" as a prefix as infinity rather than : // checking every remaining byte. > The question is whether we want to preserve this behavior (i.e. matching 'i Yeah. If we think people may depend on this functionality then we should maintain it, but it seems like a bug to me. At least I can't imagine why inf4 is any more likely to be something someone depends on than 4inf, which now has the behavior changed. The safest thing for us to do wrt backward compat is not to change the existing behavior in both cases and instead wait for C6 to make such a breaking change. We could move this new behavior into "STRICT_MODE", e.g. see commit 92fbe7bcd79d68e3ec12d767b2c4f079d5c1ab54 , so perhaps we should try to do that. -- To view, visit http://gerrit.cloudera.org:8080/3622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e17d0f051b300a22a520ce34e276c2d4460d35e Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
