Henry Robinson has posted comments on this change. Change subject: IMPALA-3859: Don't log file data on parse errors ......................................................................
Patch Set 1: I'd like to get opinions on whether removing the logging is the right thing to do. My view is that logging sensitive data is always a bad idea, and we shouldn't try and protect it with flags or logging levels. If so, I need to rewrite the test files before this change is good to go in. -- To view, visit http://gerrit.cloudera.org:8080/3646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a604f8784a9ff7b4bf878f82ee7f56697df3272 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: No
