Henry Robinson has posted comments on this change. Change subject: IMPALA-3859: Don't log file data on parse errors ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3646/1/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: Line 625: if (!state_->LogHasSpace()) return; > I don't think this makes sense any more now that we dedup, and also LogErro Done http://gerrit.cloudera.org:8080/#/c/3646/1/be/src/exec/hdfs-scanner.h File be/src/exec/hdfs-scanner.h: PS1, Line 335: This is called : /// from ReportTupleParseError() > This makes it seem like it's only called from ReportTupleParseError(). It's Done -- To view, visit http://gerrit.cloudera.org:8080/3646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a604f8784a9ff7b4bf878f82ee7f56697df3272 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
