Lars Volker has posted comments on this change. Change subject: IMPALA-3376: Extra definition level when writing Parquet files ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3556/4/be/src/util/parquet-reader.cc File be/src/util/parquet-reader.cc: Line 152: decompressed_buffer.reserve(header.uncompressed_page_size); I think you should call resize() so the buffer is actually initialized. Documentation for data() says "The pointer is such that range [data(); data() + size()) is always a valid range...". Just using reserve() means size() == 0 and then that guarantee wouldn't hold. -- To view, visit http://gerrit.cloudera.org:8080/3556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cafd7ef6b607ce6f815072b8af7395a892704d9 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
