Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3376: Extra definition level when writing Parquet files ......................................................................
Patch Set 6: Code-Review+1 (6 comments) http://gerrit.cloudera.org:8080/#/c/3556/6/be/src/util/parquet-reader.cc File be/src/util/parquet-reader.cc: PS6, Line 149: uint8_t* const http://gerrit.cloudera.org:8080/#/c/3556/6/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: PS6, Line 13: SkipIf I don't see this used? PS6, Line 157: nit: 4 spaces PS6, Line 161: parque parquet PS6, Line 179: if f.endswith('parq'): nit: save a the next level of nesting by reversing this, and continuing if not parq. PS6, Line 183: # clean up not necessary -- To view, visit http://gerrit.cloudera.org:8080/3556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cafd7ef6b607ce6f815072b8af7395a892704d9 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
