Henry Robinson has posted comments on this change. Change subject: IMPALA-3804: Push per-split filtering into scanners ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3561/2//COMMIT_MSG Commit Message: PS2, Line 23: The Parquet scanner does something : different: it processes all splits for one file on the same thread, and : so marks all those splits as 'complete' very early on. > I think this is an incorrect statement. It only marks all files as "done", Yep, good point, thanks! I misread the conditional on line 150 (the comment doesn't help and needs clarification). I'l rework this and resubmit. -- To view, visit http://gerrit.cloudera.org:8080/3561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f92178f642695e0e9ef901373a5e9f2878a78ce Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
