Dan Hecht has posted comments on this change. Change subject: IMPALA-3804: Push per-split filtering into scanners ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3561/3/be/src/exec/base-sequence-scanner.cc File be/src/exec/base-sequence-scanner.cc: Line 131: split->Cancel(Status::CANCELLED); split hasn't been issued yet, right? so does it make sense to cancel it? http://gerrit.cloudera.org:8080/#/c/3561/3/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: Line 243: filter_ctxs_); would be easier to read using standard short circuiting: !debug_file_skipping_enabled && PartitionIsFilteredOut(); I would even get rid of the "filtered" variable and apply demorgan's (and rename the temp to match the flag more closely): if (debug_skip_file_runtime_filtering || !PartitionIsFilteredOut()) Line 249: RangeComplete(v.first, file->file_compression); was this a bug in the old code? why didn't it cause problems? was it just that the stats were off? -- To view, visit http://gerrit.cloudera.org:8080/3561 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f92178f642695e0e9ef901373a5e9f2878a78ce Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
