Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks ......................................................................
Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/3282/11/be/src/util/stopwatch.h File be/src/util/stopwatch.h: Line 241: ScopedStopWatch(T* sw, bool enabled = true) : > I was thinking along the lines of a more straightforward solution to the sp That doesn't work if you do any kind of early return. E.g. RETURN_IF_ERROR() will leave the stopwatch running. It's hard to find timing bugs with profile counters so I'd rather stick with a scoped timer pattern that avoids the possibility. -- To view, visit http://gerrit.cloudera.org:8080/3282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d7608181eeacfe706a09c1e153d0a3e1ee9b475 Gerrit-PatchSet: 11 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
