Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567: Part 1: groundwork to make Join build sides DataSinks ......................................................................
Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/3282/16//COMMIT_MSG Commit Message: Line 18: Partially refactor join nodes that so control flow between > so that the Done Line 21: subclasses: ConstructBuildSide(). Once we convert all join nodes > ConstructJoinBuild() Done http://gerrit.cloudera.org:8080/#/c/3282/16/be/src/exec/blocking-join-node.h File be/src/exec/blocking-join-node.h: Line 101: /// Constructs the join build from the right child's output. Note that this can be > Aren't build side and probe side standard terms? Something like: ProcessBuildInput() or ConsumeBuildInput()? That focuses on the fact that it consumes the whole build-side input, leaving the fact that it builds some data structures implicit. -- To view, visit http://gerrit.cloudera.org:8080/3282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d7608181eeacfe706a09c1e153d0a3e1ee9b475 Gerrit-PatchSet: 16 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
