Marcel Kornacker has posted comments on this change. Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3686/2/be/src/runtime/query-exec-state.h File be/src/runtime/query-exec-state.h: Line 42: > Other things I'd expect to see in this class: i suggest we do that migration of this new class gets in. also, RuntimeState should refer back to QueryExecState. http://gerrit.cloudera.org:8080/#/c/3686/2/be/src/service/fragment-mgr.h File be/src/service/fragment-mgr.h: PS2, Line 80: std::shared_ptr< > Don't disagree with the destructor concerns, but there's a use case that we GetQueryExecState() could increment the refcount before returning without getting a lock on anything in the actual state struct. we'll end up with a good amount of unrelated per-query state in there, so getting a lock preemptively would be bad for performance anyway. (i would image we'll end up with a number of r/w locks in the query exec state, and there'll be some per-query constants in there that won't require any locks.) did i miss your point? what was your point? :) -- To view, visit http://gerrit.cloudera.org:8080/3686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c513d08f718699ba0c4cdb90c117aaecf95d7fc Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
