Henry Robinson has posted comments on this change. Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3686/2/be/src/service/fragment-mgr.h File be/src/service/fragment-mgr.h: PS2, Line 80: std::shared_ptr< > Right, but this point will come up again for IMPALA-3825, where the lifetim If you look earlier, you'll see I suggest an explicit ref count managed by fragments to deal with registration lifetime, but a shared_ptr to deal with QES object lifetime. And I don't think having the debug handlers explicitly manage ref counts is a good idea. For IMPALA-3825 you might need to rethink this and tie QES registration lifetime to the coordinator - but that might just mean the fragment aggregator adds one to the QES's refcount. This is a different requirement to the one for batching. Let's talk about that separately. -- To view, visit http://gerrit.cloudera.org:8080/3686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c513d08f718699ba0c4cdb90c117aaecf95d7fc Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
