Michael Ho has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3401/6/be/src/codegen/constant-replacement.h File be/src/codegen/constant-replacement.h: PS6, Line 35: struct ReplaceableSymbol { > I think I'd rather avoid special-casing the zero argument case too much. Ma Thanks. This makes more sense to me now after I re-read various sub-classes of ConstantReplacer. In essence, ReplaceOneArg() is the vehicle for generating the constant based on the input value. http://gerrit.cloudera.org:8080/#/c/3401/7/be/src/codegen/constant-replacement.h File be/src/codegen/constant-replacement.h: PS7, Line 130: Can it just be SimpleConstantReplacer ? http://gerrit.cloudera.org:8080/#/c/3401/7/be/src/exprs/expr-constant-replacement.cc File be/src/exprs/expr-constant-replacement.cc: PS7, Line 81: Is it possible to do it as a LLVM pass too so we can unify multiple different locations of constant replacement ? http://gerrit.cloudera.org:8080/#/c/3401/7/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: PS7, Line 184: class CpuInfoConstantReplacer : public ConstantReplacer Is it possible to nest this class inside CpuInfo class instead ? -- To view, visit http://gerrit.cloudera.org:8080/3401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ba029ed8589698eb15dbfb0a20dd2a7ea752635 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
