Hello Henry Robinson, Internal Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3615
to look at the new patch set (#9).
Change subject: IMPALA-3159: impala-shell does not accept wildcard or SAN
certificates
......................................................................
IMPALA-3159: impala-shell does not accept wildcard or SAN certificates
The impala-shell could not accept wildcard or SAN certificates
previously as the thrift library it depended on did not support them.
This patch subclasses TSSLSocket and adds the logic to take care of
the above mentioned cases by introducing the new
TSSLSocketWithWildcardSAN class.
The certificate matching logic is based on the python-ssl source code.
Added custom cluster tests to test both wildcard matching and SAN
matching.
Added be/src/testutil/certificates-info.txt which contains all the
information about the certificates which are added for the tests.
This has been tested with Python2.4 and Python2.6.
Change-Id: I8908f05afe4a6da9713fd303c499c50f692985ef
---
A be/src/testutil/certificates-info.txt
A be/src/testutil/incorrect-commonname-cert.key
A be/src/testutil/incorrect-commonname-cert.pem
A be/src/testutil/wildcard-cert.key
A be/src/testutil/wildcard-cert.pem
A be/src/testutil/wildcard-san-cert.key
A be/src/testutil/wildcard-san-cert.pem
A be/src/testutil/wildcardCA.key
A be/src/testutil/wildcardCA.pem
A shell/TSSLSocketWithWildcardSAN.py
M shell/impala_client.py
M tests/custom_cluster/test_client_ssl.py
M tests/shell/util.py
13 files changed, 509 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/15/3615/9
--
To view, visit http://gerrit.cloudera.org:8080/3615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8908f05afe4a6da9713fd303c499c50f692985ef
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
