Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3159: impala-shell does not accept wildcard or SAN certificates ......................................................................
Patch Set 9: (2 comments) As we spoke, the SAN workaround does not work on all machines I realized. So I've changed the test to x-fail if it isn't able to retrieve the SAN from the certificate. http://gerrit.cloudera.org:8080/#/c/3615/9/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: PS9, Line 111: # This block of code is the same as _validate_positive_cases() but we want to check : # if retrieving the SAN is supported first. : args = "--ssl -q 'select 1 + 2' --ca_cert=%s/wildcardCA.pem" \ : % self.CERT_DIR : result = run_impala_shell_cmd_no_expect(args) : if self.SAN_UNSUPPORTED_ERROR in result.stderr: : pytest.xfail("Running with a RHEL/Python combination that has a bug where Python " : "cannot retrieve SAN from certificate: " : "https://bugzilla.redhat.com/show_bug.cgi?id=928390";) This is where I do the verification of the output to check whether to x-fail the test or not. http://gerrit.cloudera.org:8080/#/c/3615/9/tests/shell/util.py File tests/shell/util.py: PS9, Line 95: def run_impala_shell_cmd_no_expect(shell_args, stdin_input=None): : """Runs the Impala shell on the commandline. : : 'shell_args' is a string which represents the commandline options. : Returns a ImpalaShellResult. : : Does not assert based on success or failure of command. : """ : p = ImpalaShell(shell_args) : result = p.get_result(stdin_input) : cmd = "%s %s" % (SHELL_CMD, shell_args) : return result I had to add this function to allow the test to verify the output of the shell command before x-failing. -- To view, visit http://gerrit.cloudera.org:8080/3615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8908f05afe4a6da9713fd303c499c50f692985ef Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
