Michael Brown has posted comments on this change. Change subject: IMPALA-3864: qgen: reduce likelihood of create_query() exceptions ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3720/1/tests/comparison/query_generator.py File tests/comparison/query_generator.py: PS1, Line 1473: from model_translator import SqlWriter : : NUM_TABLES = 5 : NUM_COLS_EACH_TYPE = 10 : NUM_QUERIES = 3000 > I'd expect to find these at the top of the file. Why here? They are not needed when using this as a module (i.e., importing query_generator). They are only needed when running __main__, which is only done for ad hoc testing of the QueryGenerator object. You'll notice all the symbols involved only appear below this point, within the __main__ scope. -- To view, visit http://gerrit.cloudera.org:8080/3720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd9434a92973176aefb99e11e039209cac3cea65 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
