Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3864: qgen: reduce likelihood of create_query() exceptions ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3720/3/tests/comparison/query_profile.py File tests/comparison/query_profile.py: PS3, Line 90: And > No, but the way the signature selection works, And and Or could be selected Ok that makes sense. I suggest to leave as is and add a note (maybe above CONJUNCT_DISJUNCTS) explaining why And/Or appear in both relational funcs and conjunct_disjuncts. -- To view, visit http://gerrit.cloudera.org:8080/3720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd9434a92973176aefb99e11e039209cac3cea65 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
