Michael Brown has posted comments on this change. Change subject: IMPALA-2013: Issue Hbase queries individually during data-load. ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/3728/2/bin/load-data.py File bin/load-data.py: PS2, Line 93: HIVE_ARGS = '-n %s -u "jdbc:hive2://%s/default;%s" --verbose=true'\ : % (getpass.getuser(), options.hive_hs2_hostport, hive_auth) Since you're making other fixes along the same vein in this file, wrap the string in parens and remove the use of \ and % ? PS2, Line 148: if 'ERROR' in stdout: Were you able to test this path? Is it reasonable reliable that all failures will match this, or is it possible we get failures in which no ERROR was printed to stdout, but instead something was printed to stderr, for example? PS2, Line 149: error = [l.strip() for l in stdout.split('\n') if 'ERROR' in l][0] I think this is sufficiently complex for you to provide in comments what stdout (and stderr, if applicable) look like when there's an ERROR. That will help us understand the parsing you're doing here. PS2, Line 154: except IOError: : LOGGER.error("Unable to excute HBase queries: couldn't open input file.") Is this referring to a failure in the with open()? Is this at the correct indent level? PS2, Line 304: # pdb.set_trace() Remove -- To view, visit http://gerrit.cloudera.org:8080/3728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I911d972ba8ad3a2a084c8195074556153722c7e2 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Harrison Sheinblatt <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
