Michael Brown has posted comments on this change.

Change subject: IMPALA-2013: Issue Hbase queries individually during data-load.
......................................................................


Patch Set 3:

(2 comments)

I took the liberty of marking done 2 things you fixed in ps3 that I had noted 
in ps2.

http://gerrit.cloudera.org:8080/#/c/3728/2/bin/load-data.py
File bin/load-data.py:

PS2, Line 154:   except IOError:
             :     LOGGER.error("Unable to excute HBase queries: couldn't open 
input file.")
> Is this referring to a failure in the with open()? Is this at the correct i
Done


PS2, Line 304:     # pdb.set_trace()
> Remove
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I911d972ba8ad3a2a084c8195074556153722c7e2
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: David Knupp <[email protected]>
Gerrit-Reviewer: Harrison Sheinblatt <[email protected]>
Gerrit-Reviewer: Ishaan Joshi <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-HasComments: Yes

Reply via email to