Tim Armstrong has posted comments on this change. Change subject: IMPALA-2700: ASCII NUL characters are doubled on insert into text tables ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3703/2/be/src/exec/hdfs-text-table-writer.cc File be/src/exec/hdfs-text-table-writer.cc: Line 209: rowbatch_stringstream_ << str_val->ptr[i]; This isn't right - it assumes that the StringValue is NULL-terminated. So we could overrun ptr the pointer buffer (maybe crashing Impala or printing sensitive data) or incorrectly truncate it if there is a NULL character in the buffer. We should also add a query test. E.g. in the IMPALA-2700 JIRA I had a simple reproduction of the problem that would catch some problems like this. -- To view, visit http://gerrit.cloudera.org:8080/3703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia30fa314d1ee1e99f9e7598466eb1570ca7940fc Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
