Tim Armstrong has posted comments on this change.

Change subject: IMPALA-2700: ASCII NUL characters are doubled on insert into 
text tables
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3703/3/tests/query_test/test_insert_behaviour.py
File tests/query_test/test_insert_behaviour.py:

Line 83:   @pytest.mark.execute_serially
You should be able to avoid executing this serially if you use the 
unique_database argument. That will automatically create a database and destroy 
it after the test.

e.g. see test_insert_file_permissions below.


Line 86:     self.execute_query_expect_success(self.client, "DROP TABLE IF 
EXISTS %s" % TBL_NAME)
This drop table and the one below shouldn't be necessary with unique_database.


PS3, Line 90: %
Missing sapace after %


-- 
To view, visit http://gerrit.cloudera.org:8080/3703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia30fa314d1ee1e99f9e7598466eb1570ca7940fc
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to